Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix NPM package type resolution mismatch #972

Merged
merged 3 commits into from
Apr 23, 2024
Merged

Fix NPM package type resolution mismatch #972

merged 3 commits into from
Apr 23, 2024

Conversation

jwerle
Copy link
Member

@jwerle jwerle commented Apr 23, 2024

No description provided.

@jwerle jwerle added bug Something isn't working javascript An issue, discussion, or task related to the runtime javascript api An issue, task, or discussion related to public runtime APIs runtime An issue, task, or discussion related to the runtime core labels Apr 23, 2024
@jwerle jwerle self-assigned this Apr 23, 2024
heapwolf
heapwolf approved these changes Apr 23, 2024
View reviewed changes
Copy link
Member

@heapwolf heapwolf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

None of the requests in the service worker debugger fail now.

@jwerle jwerle merged commit d20a70b into next Apr 23, 2024
4 of 5 checks passed
@jwerle jwerle deleted the fix-npm-package-type-resolution-mismatch branch April 23, 2024 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@heapwolf heapwolf heapwolf approved these changes

Assignees

@jwerle jwerle

Labels
api An issue, task, or discussion related to public runtime APIs bug Something isn't working javascript An issue, discussion, or task related to the runtime javascript runtime An issue, task, or discussion related to the runtime core
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jwerle @heapwolf